Update charts to support queue modes and queue depth scaling#1244
Merged
alexellis merged 4 commits intoopenfaas:masterfrom Jul 25, 2025
Merged
Update charts to support queue modes and queue depth scaling#1244alexellis merged 4 commits intoopenfaas:masterfrom
alexellis merged 4 commits intoopenfaas:masterfrom
Conversation
alexellis
reviewed
Jul 24, 2025
alexellis
reviewed
Jul 24, 2025
alexellis
reviewed
Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates OpenFaaS charts to support new queue modes and queue depth scaling capabilities. The changes transition from a legacy queue system to a modern JetStream-based architecture with improved scalability and configuration options.
- Refactored queue worker configuration to support both static and function-based queue modes
- Added queue depth scaling metric recording rule for Prometheus monitoring
- Removed deprecated global
queueModeparameter in favor of automatic JetStream usage for OpenFaaS Pro
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chart/queue-worker/values.yaml | Added new queue configuration parameters and consumer settings |
| chart/queue-worker/templates/deployment.yaml | Updated environment variables to support new queue modes and reorganized configuration |
| chart/queue-worker/README.md | Updated documentation with new configuration parameters and corrected typos |
| chart/openfaas/values.yaml | Removed deprecated queueMode parameter and updated JetStream worker configuration |
| chart/openfaas/values-pro.yaml | Removed deprecated JetStream queue mode setting |
| chart/openfaas/templates/queueworker-dep.yaml | Refactored to use JetStream queue worker for OpenFaaS Pro |
| chart/openfaas/templates/queueworker-ce-dep.yaml | New template for Community Edition queue worker |
| chart/openfaas/templates/prometheus-pro-cfg.yaml | Added recording rule for queue depth scaling metrics |
| chart/openfaas/templates/nats-dep.yaml | Updated NATS deployment logic to use OpenFaaS Pro flag |
| chart/openfaas/templates/jetstream-queueworker-dep.yaml | Removed deprecated JetStream queue worker template |
| chart/openfaas/templates/gateway-dep.yaml | Removed deprecated JetStream environment variable |
| chart/openfaas/README.md | Updated documentation to reflect new queue configuration |
Comments suppressed due to low confidence (2)
chart/openfaas/values.yaml:223
- This appears to be a development/testing image from ttl.sh. For a production chart, this should be changed to an official release image from the proper registry.
image: ttl.sh/welteki/jetstream-queue-worker:0.3.46-30-g1c16703
chart/openfaas/templates/queueworker-dep.yaml:80
- [nitpick] Environment variable name is inconsistent with other environment variables. Should be
consumer_inactive_thresholdto match the pattern used for other consumer-related variables.
- name: "inactive_threshold"
Member
|
Seems valid 
|
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
queueModeparameter. The queue-worker backed by NATS JetStream is now always used whenopenfaasPro=trueWhy is this needed?
Update chart for new queue worker
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Verified the chart renders correctly using
helm template.Types of changes
Checklist:
git commit -s